Display scmsync package actions #18372

hellcp-work · 2025-08-15T08:20:32Z

Displaying a reduced view of the packages coming from the remote scm

obs-bot · 2025-08-15T09:00:13Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

adrianschroeter · 2025-08-15T11:56:57Z

could you hide this version of the sources by default?

These are not the sources which are processed when rpmbuild runs and neither what is maintained in git.

Esp. when we start now using subdirectories it willl lead to confusion... so, maybe just collapsing it and show it only on request (mouse click).

Also, the scmsync url itself seems not to be displayed. The showing URL is the project url from tag, right?

hellcp-work · 2025-08-15T12:00:58Z

could you hide this version of the sources by default?

These are not the sources which are processed when rpmbuild runs and neither what is maintained in git.

Esp. when we start now using subdirectories it willl lead to confusion... so, maybe just collapsing it and show it only on request (mouse click).

Doable

Also, the scmsync url itself seems not to be displayed. The showing URL is the project url from tag, right?

It is, both in the project's package list and also in the top right (Developed at SCM link)

adrianschroeter · 2025-08-15T12:21:55Z

| | Also, the scmsync url itself seems not to be displayed. The showing URL is the project url from tag, right?
| It is, both in the project's package list and also in the top right (Developed at SCM link)

I see, maybe we can have that link more prominent by default. For example showing this one instead of the sources by default.

obs-bot · 2025-08-18T13:05:11Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

obs-bot · 2025-08-18T14:05:12Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

obs-bot · 2025-08-18T14:25:21Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

obs-bot · 2025-08-19T13:35:24Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

obs-bot · 2025-08-20T08:35:21Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

obs-bot · 2025-08-20T13:15:21Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

obs-bot · 2025-08-20T13:40:21Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

obs-bot · 2025-08-20T14:15:23Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

obs-bot · 2025-08-20T14:25:23Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

obs-bot · 2025-08-20T14:40:21Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

obs-bot · 2025-08-21T09:05:23Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

obs-bot · 2025-08-21T12:55:22Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

src/api/app/models/package.rb

src/api/app/controllers/webui/webui_controller.rb

src/api/app/models/project.rb

src/api/app/views/webui/project/_project_packages.html.haml

hennevogel · 2025-08-25T10:59:06Z

src/api/app/controllers/webui/webui_controller.rb

-      @package = Package.get_by_project_and_name(@project.name, @package_name, follow_multibuild: true)
+      @package = Package.get_by_project_and_name(@project.name, @package_name,
+                                                 follow_multibuild: true,
+                                                 follow_project_scmsync_links: Flipper.enabled?(:scmsync, User.session))


This will expose readonly packages to all controllers that use this before action. I don't think this is a good idea.

Added an scmsync specific method now

All this checking about Flipper.enabled?(:scmsync, User.session) getting a bit out of hand by now. Can you simplify this?

I did for the check_scmsync action

couldn't you normalize this between remote project and scmsync anyway?
What should we keep the regressions for remote projects and deal with different workarounds there?

(Technical, the only difference between an scmsync and a remote package on api level is just the permission handling for service run and lock. Everything else should be identical, including access to build states, log files and the rest of the commands).

There are multiple pull requests from me open fixing these regressions and come with test cases demonstarting the issues...

hramrach · 2025-09-03T11:22:01Z

It is, both in the project's package list and also in the top right (Developed at SCM link)

That link is bogus - see #18062

obs-bot · 2025-09-16T13:35:22Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

obs-bot · 2025-09-23T14:10:43Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

obs-bot · 2025-09-23T14:40:40Z

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package

github-actions bot added the Frontend Things related to the OBS RoR app label Aug 15, 2025

hennevogel added the review-app Apply this label if you want a review app started label Aug 15, 2025

hellcp-work force-pushed the scmsync-package branch 4 times, most recently from 7966254 to caab5fe Compare August 15, 2025 11:52

hellcp-work force-pushed the scmsync-package branch from caab5fe to fa7caf0 Compare August 18, 2025 09:59

hellcp-work force-pushed the scmsync-package branch from 607d67a to 1294f76 Compare August 19, 2025 09:54

hellcp-work force-pushed the scmsync-package branch from 1294f76 to c4389a5 Compare August 21, 2025 11:55

hennevogel reviewed Aug 21, 2025

View reviewed changes

src/api/app/models/package.rb Outdated Show resolved Hide resolved

hellcp-work force-pushed the scmsync-package branch 4 times, most recently from 09a5f37 to 0437cb8 Compare August 22, 2025 10:11

hennevogel reviewed Aug 25, 2025

View reviewed changes

src/api/app/controllers/webui/webui_controller.rb Outdated Show resolved Hide resolved

hennevogel reviewed Aug 25, 2025

View reviewed changes

src/api/app/models/project.rb Outdated Show resolved Hide resolved

hennevogel reviewed Aug 25, 2025

View reviewed changes

src/api/app/views/webui/project/_project_packages.html.haml Show resolved Hide resolved

hellcp-work force-pushed the scmsync-package branch from 0437cb8 to cefbb90 Compare August 25, 2025 10:06

hennevogel reviewed Aug 25, 2025

View reviewed changes

fwag mentioned this pull request Sep 19, 2025

[api] Fix usage of scmsync projects via project links #18522

Merged

hellcp-work force-pushed the scmsync-package branch from 3c821ff to ccaea2b Compare November 4, 2025 09:46

hellcp-work added 8 commits November 4, 2025 10:48

Add a feature flag for scmsync

f237f60

Display package list for scmsync packages

956d75d

Support package show action with scmsync

b4ab8ab

Reenable package actions

d839ab5

Only display the link to scm when first opening a package

cc6c354

Improve the way the beta is checked

1510b68

Only set the scmsync package for selected actions

b32eeb0

Check the scmsync feature toggle in the scmsync checker concern

64c881c

hellcp-work force-pushed the scmsync-package branch from ccaea2b to 64c881c Compare November 4, 2025 09:48

Display scmsync package actions #18372

Are you sure you want to change the base?

Display scmsync package actions #18372

Conversation

hellcp-work commented Aug 15, 2025

Uh oh!

obs-bot commented Aug 15, 2025

Uh oh!

adrianschroeter commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hellcp-work commented Aug 15, 2025

Uh oh!

adrianschroeter commented Aug 15, 2025

Uh oh!

obs-bot commented Aug 18, 2025

Uh oh!

obs-bot commented Aug 18, 2025

Uh oh!

obs-bot commented Aug 18, 2025

Uh oh!

obs-bot commented Aug 19, 2025

Uh oh!

obs-bot commented Aug 20, 2025

Uh oh!

obs-bot commented Aug 20, 2025

Uh oh!

obs-bot commented Aug 20, 2025

Uh oh!

obs-bot commented Aug 20, 2025

Uh oh!

obs-bot commented Aug 20, 2025

Uh oh!

obs-bot commented Aug 20, 2025

Uh oh!

obs-bot commented Aug 21, 2025

Uh oh!

obs-bot commented Aug 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hennevogel Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

hellcp-work Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

hennevogel Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

hellcp-work Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

adrianschroeter Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

hramrach commented Sep 3, 2025

Uh oh!

obs-bot commented Sep 16, 2025

Uh oh!

obs-bot commented Sep 23, 2025

Uh oh!

obs-bot commented Sep 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adrianschroeter commented Aug 15, 2025 •

edited

Loading